Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse External Tools integration #180

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Conversation

Xarthisius
Copy link
Collaborator

@Xarthisius Xarthisius commented Nov 27, 2018

This PR creates a simple endpoint that accepts requests coming from Dataverse external tools and return 303 to a proper dashboard route with an encoded datafile information.

Suggested test:

  1. Run girder with env DASHBOARD_URL set to your dashboard instance (needs Data import dashboard#287 and Add support for ingesting data from Dataverse. Fixes #179 #175)
  2. Run a dataverse with a ext tool integration pointing to <your_girder>/api/v1/integration/dataverse (remember to set DATAVERSE_URL in wholetale plugin's config)
  3. See the magic happen!

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #180 into master will increase coverage by 0.24%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   84.61%   84.86%   +0.24%     
==========================================
  Files          32       34       +2     
  Lines        2022     2061      +39     
==========================================
+ Hits         1711     1749      +38     
- Misses        311      312       +1
Impacted Files Coverage Δ
server/rest/integration.py 100% <100%> (ø)
server/__init__.py 86.46% <100%> (+0.11%) ⬆️
server/lib/dataverse/integration.py 96.66% <96.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df7f7b...036d588. Read the comment docs.

@Xarthisius Xarthisius force-pushed the dataverse_exttools branch 2 times, most recently from 7a86ecc to c706ac7 Compare November 28, 2018 16:49
Xarthisius added a commit to whole-tale/terraform_deployment that referenced this pull request Dec 3, 2018
@Xarthisius Xarthisius merged commit 4183599 into master Dec 3, 2018
@Xarthisius Xarthisius deleted the dataverse_exttools branch December 5, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants